linux-kernel - Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <806dafc20701250903p6b67d176wf00dd2a9d92d899f@mail.gmail.com>
Date:	Thu, 25 Jan 2007 12:03:12 -0500
From:	"Christopher \"Monty\" Montgomery" <xiphmont@...il.com>
To:	"Takashi Iwai" <tiwai@...e.de>
Cc:	"Pierre Ossman" <drzeus@...eus.cx>, fedora-desktop-list@...hat.com,
	alsa-devel@...a-project.org, jrb@...hat.com,
	"Greg KH" <greg@...ah.com>, linux-kernel@...r.kernel.org,
	mclasen@...hat.com, "Lennart Poettering" <lennart@...ttering.net>,
	perex@...e.cz
Subject: Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

> > What was there (plugging the old 'dev' arg into the new call's
> > 'parent' makes no sense) is clearly wrong.
>
> It makes sense because the meaning of card->dev was changed, too.
> Now it points the "card*" object that is the root of all belonging
> devices.  The former card->dev is stored in card->parent.

Unfortunately card->parent does not work... but card->dev->parent does...

> > And it's clear my pacth is incomplete, as it doesn't correct the
> > device entries for the other entries.
>
> Well, for older systems, we shouldn't have also "card*" objects, too.

True enough.

> An untested patch below...

This patch does not correct the problem, unfortunately.  I had
originally tried something similar, but card->parent still results in
the device symlink pointing to ../../../class/cardN.

I'm working on this now and will doublecheck just in case my test was
flawed first time.

Monty
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/