linux-kernel - Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <806dafc20701250930n185e9773i64bbd2d845c836be@mail.gmail.com>
Date:	Thu, 25 Jan 2007 12:30:44 -0500
From:	xiphmont@...h.org
To:	"Takashi Iwai" <tiwai@...e.de>
Cc:	"Pierre Ossman" <drzeus@...eus.cx>, fedora-desktop-list@...hat.com,
	alsa-devel@...a-project.org, jrb@...hat.com,
	"Greg KH" <greg@...ah.com>, linux-kernel@...r.kernel.org,
	mclasen@...hat.com, "Lennart Poettering" <lennart@...ttering.net>,
	perex@...e.cz
Subject: Re: [Alsa-devel] [PATCH] alsa: correct nonsensical sysfs device symlinks

> I'm working on this now and will doublecheck just in case my test was
> flawed first time.

Doublechecking indicates my initial test was wrong somehow; both
card->dev->parent and card->parent passed as arg 2 to the
device_create call in snd_register_device result in correct device
symlinks. Are these two actually semantically different?  I'm just
curious.

The call to device_create in cound_core.c:sound_insert_unit also needs
to be modified in order for the device symlinks in the other unit
types to be correct.  Again, modifying the 'dev' argument to
'(dev?dev->parent:NULL)' appears to fix the problem.  Is that
correct/appropriate there?

Monty
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/