linux-kernel - Re: mm snapshot broken-out-2007-01-26-00-36.tar.gz uploaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070126153832.GB12550@sergelap.austin.ibm.com>
Date:	Fri, 26 Jan 2007 09:38:32 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	"Serge E. Hallyn" <serue@...ibm.com>
Cc:	Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>,
	Herbert Poetzl <herbert@...hfloor.at>,
	Oleg Nesterov <oleg@...sign.ru>,
	Cedric Le Goater <clg@...ibm.com>,
	Daniel Hokka Zakrisson <daniel@...ac.com>
Subject: Re: mm snapshot broken-out-2007-01-26-00-36.tar.gz uploaded

Quoting Serge E. Hallyn (serue@...ibm.com):
> Quoting Michal Piotrowski (michal.k.k.piotrowski@...il.com):
> > Hi Serge,
> > 
> > akpm@...l.org napisa?(a):
> > > The mm snapshot broken-out-2007-01-26-00-36.tar.gz has been uploaded to
> > > 
> > >    ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-01-26-00-36.tar.gz
> > > 
> > > It contains the following patches against 2.6.20-rc6:
> > > 
> > > origin.patch
> > [..]
> > > namespaces-fix-exit-race-by-splitting-exit.patch
> > [..]
> > 
> > I'm receiving an error
> > 
> > In file included from /mnt/md0/devel/linux-work5/include/linux/sched.h:87,
> >                  from /mnt/md0/devel/linux-work5/include/linux/utsname.h:35,
> >                  from include2/asm/elf.h:12,
> >                  from /mnt/md0/devel/linux-work5/include/linux/elf.h:7,
> >                  from /mnt/md0/devel/linux-work5/include/linux/module.h:15,
> >                  from /mnt/md0/devel/linux-work5/include/linux/crypto.h:21,
> >                  from /mnt/md0/devel/linux-work5/arch/i386/kernel/asm-offsets.c:7:
> > /mnt/md0/devel/linux-work5/include/linux/nsproxy.h: In function 'preexit_task_namespaces':
> > /mnt/md0/devel/linux-work5/include/linux/nsproxy.h:56: error: dereferencing pointer to incomplete type
> > make[2]: *** [arch/i386/kernel/asm-offsets.s] Error 1
> > make[1]: *** [prepare0] Error 2
> > make: *** [_all] Error 2
> > 
> > Regards,
> > Michal
> 
> Sorry, I don't know where to get a series file for this patchset?
> 
> It sounds like your tree doesn't #include <linux/sched.h> at the top of
> include/linux/nsproxy.h.  That was added by a separate patch I think
> last week - a few architectures (which i was testing) had a #include chain
> which ended up in sched.h being included free, but some arches had a
> different chain.
> 
> Anyway please try #include <linux/sched.h> at the top of
> include/linux/nsproxy.h and let me know if that doesn't fix the problem.

No, I just found Cedric's patch removing the include.

So moving preexit_task_namespaces() into nsproxy.c is the right way to
go.

thanks,
-serge
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/