linux-kernel - Re: [PATCH] libata: fix translation for START STOP UNIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45BF5525.5040709@garzik.org>
Date:	Tue, 30 Jan 2007 09:24:37 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Robert Hancock <hancockr@...w.ca>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org
Subject: Re: [PATCH] libata: fix translation for START STOP UNIT

Robert Hancock wrote:
> Applies to 2.6.20-rc6.
> 
> ---
> 
> libata's SCSI translation for the SCSI START STOP UNIT command with the 
> START bit clear (i.e. stopping the drive) appears to be incorrect. It 
> sends an ATA STANDBY command with the time period set to 0, which the 
> code comment says means "now", but the ATA standard says this means 
> disable the standby timer, which effectively does nothing. Change this 
> to issue a STANDBY IMMEDIATE command which will actually spin the drive 
> down. The SAT (SCSI/ATA Translation) standard revision 9 concurs with 
> this choice.
> 
> Signed-off-by: Robert Hancock <hancockr@...w.ca>

FWIW, I am having to apply Andrew Morton's version of your patches, 
because your patch form isn't quite right.  Review 
Documentation/SubmittingPatches and http://linux.yyz.us/patch-format.html

Most notably:

* Your patch description follows the "---" terminator, which is 
precisely the opposite of what should happen.  In the correct form, any 
comments such as "Applies to 2.6.20-rc6" should follow the "---" 
terminator, which in turn follows the patch description and signoff.

* Include the patch inline rather than as an attachment.  Even a 
text/plain attachment is very difficult to review and quote in popular 
email programs.

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/