linux-kernel - Re: [PATCH 16/23] clocksource: arm update for new flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070131122710.GF1847@elte.hu>
Date:	Wed, 31 Jan 2007 13:27:10 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org, johnstul@...ibm.com,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 16/23] clocksource: arm update for new flags

* Daniel Walker <dwalker@...sta.com> wrote:

> Update ARM for new flags.
> 
> Signed-Off-By: Daniel Walker <dwalker@...sta.com>

> -	.flags		= CLOCK_SOURCE_IS_CONTINUOUS,

see my general objection to this change (under the [PATCH 22/23] 
subject), but even looking at the pure patch note that it does the flag 
update incorrectly and in a bisect-boot-unfriendly way: the queue at 
this point changes kernel functionality and has side-effects. The right 
way to do flags updates is to first introduce them, then change things 
over.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/