lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 31 Jan 2007 13:43:00 +0100 From: Ingo Molnar <mingo@...e.hu> To: Daniel Walker <dwalker@...sta.com> Cc: akpm@...l.org, linux-kernel@...r.kernel.org, johnstul@...ibm.com, Thomas Gleixner <tglx@...utronix.de> Subject: Re: [PATCH 23/23] clocksource tsc: add verify routine * Daniel Walker <dwalker@...sta.com> wrote: > I've included this as another user of the clocksource interface. I > don't see a usage for this across all achitectures. So a fully generic > version isn't needed. well, this implementation is buggy in at least two ways: firstly, it allows a circular verification dependency in highres+dyntick mode between the jiffies and tsc clocksources. secondly, verification is not done while the system is booting up: > static void verify_tsc_freq(unsigned long unused) > { [...] > + if (unlikely(system_state != SYSTEM_RUNNING)) > + goto out_timer; so we should just go with Thomas' patch: clocksource-add-verification-watchdog-helper.patch which has been based on and tested on actual systems affected by these problems. Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists