[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0702010546400.13434@CPE00045a9c397f-CM001225dbafb6>
Date: Thu, 1 Feb 2007 05:49:28 -0500 (EST)
From: "Robert P. J. Day" <rpjday@...dspring.com>
To: David Howells <dhowells@...hat.com>
cc: Linux kernel mailing list <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...l.org>,
Paul Mackerras <paulus@...ba.org>, galak@...nel.crashing.org
Subject: Re: [PATCH] Add "is_power_of_2" checking to log2.h.
On Thu, 1 Feb 2007, David Howells wrote:
>
> Robert P. J. Day <rpjday@...dspring.com> wrote:
>
> > +#define is_power_of_4(x) is_power_of_2(x) && (ffs(x) & 1))
>
> If this is such a commonly implemented op, it should probably be implemented
> globally too.
there are only two checks of the form "is_power_of_4" in the entire
tree, and they're both in the power pc stuff, so i doubt it's worth
trying to formalize that in any way.
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://www.fsdev.dreamhosters.com/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists