lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 1 Feb 2007 14:26:48 -0800
From:	Andrew Morton <>
To:	TJ <>
Cc:	OGAWA Hirofumi <>,
	Neil Brown <>,
Subject: Re: [PATCH 1/1] filesystem: Disk Errors at boot-time caused by
 probe of partitions

On Wed, 31 Jan 2007 23:50:39 +0000
TJ <> wrote:

> +		if (!insane && is_extended_partition(p)) { /* check the extended partition */
> +			data = read_dev_sector(bdev, START_SECT(p)*sector_size, &sect); /* fetch sector from cache */
> +			if (data) {
> +				if (msdos_magic_present(data + 510)) { /* check for signature */
> +					ext = (struct partition *) (data + 0x1be);
> +					ret = check_sane_values(ext, bdev); /* recursive call */

The recursion is a concern.  Is there any way in which a cunningly-crafted
device can cause sufficiently deep recursion to crash the kernel?

Also, from reading the replies I think we'd like to see some more
explanation of why this is necessary: are you really really sure that those
disks were incorrectly handling illegal sector numbers?  Knowing the IBM
and Maxtor model numbers might be useful.

I assume you were using a driver in drivers/ide/?  Perhaps this is really
an IDE-layer bug.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists