linux-kernel - RE: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctlprocessing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <0631C836DBF79F42B5A60C8C8D4E82298ED5D6@NAMAIL2.ad.lsil.com>
Date:	Wed, 7 Feb 2007 19:54:38 -0700
From:	"Patro, Sumant" <Sumant.Patro@....com>
To:	"James Bottomley" <James.Bottomley@...elEye.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	<linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	"Kolli, Neela" <Neela.Kolli@....com>, "Yang, Bo" <Bo.Yang@....com>
Subject: RE: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for ioctlprocessing

Thanks.
I will resubmit the patch.

Regards,
Sumant 

-----Original Message-----
From: James Bottomley [mailto:James.Bottomley@...elEye.com] 
Sent: Wednesday, February 07, 2007 2:02 PM
To: Andrew Morton
Cc: Patro, Sumant; linux-scsi@...r.kernel.org;
linux-kernel@...r.kernel.org; Kolli, Neela; Yang, Bo; Patro, Sumant
Subject: Re: [PATCH 4/5] scsi: megaraid_sas - preallocate memory for
ioctlprocessing

On Wed, 2007-02-07 at 13:30 -0800, Andrew Morton wrote:
> I suspect all this horror is due to stupidity in the DMA API.
> 
> pci_alloc_consistent() just goes and assumes GFP_ATOMIC, whereas the 
> caller (megasas_mgmt_fw_ioctl) would have been perfectly happy to use 
> GFP_KERNEL.
> 
> I bet this fixes it

It does, but the DMA API was expanded to cope with this exact case, so
use dma_alloc_coherent() directly in the megaraid code instead.  The dev
is just &pci_dev->dev.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/