| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 09 Feb 2007 17:02:26 +0100 From: Stefan Richter <stefanr@...6.in-berlin.de> To: Pavel Pisa <pisa@....felk.cvut.cz> CC: Russell King - ARM Linux <linux@....linux.org.uk>, linux-kernel@...r.kernel.org, Sascha Hauer <s.hauer@...gutronix.de>, Pierre Ossman <drzeus@...eus.cx> Subject: Re: Coding style question Pavel Pisa wrote: > There are tightly copled two macros for preparation > and acquisition of muti-bit masked fields values > > #define __val2mfld(mask,val) (((mask)&~((mask)<<1))*(val)&(mask)) > > #define __mfld2val(mask,val) (((val)&(mask))/((mask)&~((mask)<<1))) The macro names are awkward. http://lxr.linux.no/source/Documentation/CodingStyle?v=2.6.18#L133 Consider longer names (and to partially counteract column consumption, omit the leading underscores) or at least spell their purpose out in a short comment at the macro definitions. -- Stefan Richter -=====-=-=== --=- -=--= http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists