| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 10 Feb 2007 21:43:00 +0100 From: Richard Knutsson <ricknu-0@...dent.ltu.se> To: James Bottomley <James.Bottomley@...elEye.com> CC: linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org Subject: Re: [PATCH] drivers/scsi/aic7xxx_old: Convert to generic boolean-values James Bottomley wrote: > On Sat, 2007-02-10 at 18:46 +0100, Richard Knutsson wrote: > >> Convert: >> FALSE -> false >> TRUE -> true >> > > Actually, downcasing true and false in this driver is pretty much a > retrograde step. The reason for their being uppercased is that they > represent constants (and uppercase is the traditional defined constant > specifier). > > When discussion about TRUE and FALSE came up a long time a go in the > context of the mid layer we agreed to strip the defined constants out of > that code and just go with 1 and 0 inline ... because the code was > pretty much being rewritten. We also decided to encourage but not force > the driver writers simply to use 1 and 0 as well ... a lot of people are > deeply wedded to the TRUE and FALSE defines, it turned out. > Btw, is this just for aic7xxx_old and not aic7xxx? Is it going to be replaced? In that case, I will just leave it alone. Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists