linux-kernel - [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k5yp90v1.fsf@sonic.technologeek.org>
Date:	Sat, 10 Feb 2007 22:08:50 +0100
From:	Julien BLACHE <jb@...ache.org>
To:	linux-kernel@...r.kernel.org
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Marcel Holtmann <marcel@...tmann.org>,
	Jiri Kosina <jkosina@...e.cz>
Subject: [PATCH] Fix USB vendor and product IDs endianness for USB HID devices

Hi,

The generic HID layer changes introduced an endianness bug for USB HID
devices.

The USB vendor and product IDs are not byteswapped appropriately, and
thus come out in the wrong endianness when fetched through the evdev
using ioctl() on big endian platforms.

This byteswapping used to be done in hidinput_connect() (by
usb_to_input_id()) when filling up the hid device structure, and now
needs to be done upstream. USB is the only user so far, and the
hid_device structure is set up in usb_hid_configure().

Signed-off-by: Julien BLACHE <jb@...ache.org>

View attachment "usbhid_vid_pid_endianness_fix.patch" of type "text/x-diff" (498 bytes)

Please apply, and this is a candidate for -stable as it breaks a
documented API/ABI in userspace.

JB.

-- 
Julien BLACHE                                   <http://www.jblache.org> 
<jb@...ache.org>                                  GPG KeyID 0xF5D65169