linux-kernel - Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Feb 2007 17:52:27 +0100
From:	Andi Kleen <ak@...e.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Christoph Hellwig <hch@...radead.org>,
	Segher Boessenkool <segher@...nel.crashing.org>,
	patches@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH x86 for review III] [1/29] i386: avoid gcc extension

On Tuesday 13 February 2007 17:10, Randy Dunlap wrote:
> On Tue, 13 Feb 2007 16:11:14 +0100 Arnd Bergmann wrote:
> 
> > On Monday 12 February 2007 17:51, Andi Kleen wrote:
> > > setcc() in math-emu is written as a gcc extension statement expression
> > > macro that returns a value.  However, it's not used that way and it's not
> > > needed like that, so just make it a do-while non-extension macro so that we
> > > don't use an extension when it's not needed.
> > > 
> > 
> > The patch looks good but it doesn't match the description any more, since
> > you now use a function...
> 
> Hi Arnd,
> Someone else had that same comment, so I sent a corrected patch
> (description change only) to that mail.

I had already fixed it up

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/