linux-kernel - Re: [patch 02/11] syslets: add syslet.h include file, user API/ABI definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070213223241.GJ22104@elte.hu>
Date:	Tue, 13 Feb 2007 23:32:41 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Indan Zupancic <indan@....nu>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@....com.au>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Ulrich Drepper <drepper@...hat.com>
Subject: Re: [patch 02/11] syslets: add syslet.h include file, user API/ABI definitions

* Indan Zupancic <indan@....nu> wrote:

> What I propose:
> 
> 	atom1 returns 0, has SYSLET_STOP_ON_ZERO|SYSLET_SKIP_NEXT_ON_STOP set
> 	atom2
> 	atom3
> 
> (You've already used my SYSLET_SKIP_NEXT_ON_STOP instead of 
> SYSLET_SKIP_TO_NEXT_ON_STOP. ;-)

doh. Yes. I noticed and implemented this yesterday and it's in the 
submitted syslet code - but i guess i was too tired to remember my own 
code - so i added the wrong comments :-/ If you look at the sample 
user-space code:

        init_atom(req, &req->open_file, __NR_sys_open,
                  &req->filename_p, &O_RDONLY_var, NULL, NULL, NULL, NULL,
                  &req->fd, SYSLET_STOP_ON_NEGATIVE, &req->read_file);

the 'STOP_ON_NEGATIVE' acts on that particular atom.

this indeed cleaned up things quite a bit and made the user-space syslet 
code alot more straightforward. A return value can still be recovered 
and examined (with a different condition and a different jump target) 
arbitrary number of times via ret_ptr and via sys_umem_add().

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/