linux-kernel - Re: [patch 08/14] syslets: x86, add create_async

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0702151111250.11064@alien.or.mcafeemobile.com>
Date:	Thu, 15 Feb 2007 11:14:58 -0800 (PST)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Christoph Hellwig <hch@...radead.org>,
	Andrew Morton <akpm@....com.au>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Ulrich Drepper <drepper@...hat.com>,
	Zach Brown <zach.brown@...cle.com>,
	Evgeniy Polyakov <johnpol@....mipt.ru>,
	"David S. Miller" <davem@...emloft.net>,
	Suparna Bhattacharya <suparna@...ibm.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [patch 08/14] syslets: x86, add create_async_thread() method

On Thu, 15 Feb 2007, Ingo Molnar wrote:

> +ENTRY(async_thread_helper)
> +	CFI_STARTPROC
> +	/*
> +	 * Allocate space on the stack for pt-regs.
> +	 * sizeof(struct pt_regs) == 64, and we've got 8 bytes on the
> +	 * kernel stack already:
> +	 */
> +	subl $64-8, %esp
> +	CFI_ADJUST_CFA_OFFSET 64

Maybe a comment here would help in explaining why we do need space for the 
extra pt_regs (on top of the one already allocated in do_fork()) ;)
It's not immediately clear that ret_from_fork and syscall_exit will issue 
two nested RESTORE_REGS.



- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/