linux-kernel - [PATCH] DS1374: check for workqueue creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070216210844.GB10190@cvg>
Date:	Sat, 17 Feb 2007 00:08:44 +0300
From:	"Cyrill V. Gorcunov" <gorcunov@...il.com>
To:	Randy Vinson <rvinson@...sta.com>
Cc:	linux-kernel-list <linux-kernel@...r.kernel.org>
Subject: [PATCH] DS1374: check for workqueue creation

This patch checks if workqueue creation failed.
Further usage of NULL pointed workqueue is not
good I guess ;)

Signed-off-by: Cyrill V. Gorcunov <gorcunov@...il.com>

---

 drivers/i2c/chips/ds1374.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/chips/ds1374.c b/drivers/i2c/chips/ds1374.c
index 15edf40..8a2ff0c 100644
--- a/drivers/i2c/chips/ds1374.c
+++ b/drivers/i2c/chips/ds1374.c
@@ -207,6 +207,10 @@ static int ds1374_probe(struct i2c_adapter *adap, int addr, int kind)
 	client->driver = &ds1374_driver;

 	ds1374_workqueue = create_singlethread_workqueue("ds1374");
+	if (!ds1374_workqueue) {
+		kfree(client);
+		return -ENOMEM;	/* most expected reason */
+	}

 	if ((rc = i2c_attach_client(client)) != 0) {
 		kfree(client);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/