[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <OF8D0E4DD6.8DF18C46-ON85257286.00002C8B-85257286.0001FC97@de.ibm.com>
Date: Sat, 17 Feb 2007 19:21:42 -0500
From: Joachim Fenkes <FENKES@...ibm.com>
To: Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Hoang-Nam Nguyen <hnguyen@...ux.vnet.ibm.com>, johnrose@...ibm.com,
linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
paulus@...ba.org, pmac@....ibm.com, Sylvain Munaut <tnt@...tnt.com>
Subject: Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent() compatible with
ibmebus
Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote on 17.02.2007
16:56:39:
> On Sat, 2007-02-17 at 17:28 +0100, Hoang-Nam Nguyen wrote:
> > ibmebus has a fake root device that's not associated with an ofdt
node.
> > Filter out any such devices in of_device_uevent().
>
> Doh ! You are creating an of_device with no attached device-node ? That
> is totally evil ! Why do you need that ?
The driver creates a fake "ibmebus" device so all ibmebus based devices
have
a common parent device -- the vio bus does the same.
What do you think about linking this device to the device tree "/" node?
All
ibmebus-based devices are linked to dt nodes residing directly beneath
"/",
so the mapping would fit.
Cheers,
Joachim
---
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
extraordinaire
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Development
2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMail: fenkes@...ibm.com -- Phone: +49 7031 16 1239
Vorsitzender des Aufsichtsrats: Johann Weihen -- Geschäftsführung:
Herbert Kircher
Sitz der Gesellschaft: Böblingen -- Registergericht: Amtsgericht
Stuttgart, HRB 243294
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists