linux-kernel - Re: [PATCH 2.6.21-rc1] powerpc: Make of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF18F067AE.FF85D78B-ON85257287.005ADAC3-85257287.005B37D9@de.ibm.com>
Date:	Mon, 19 Feb 2007 11:36:23 -0500
From:	Joachim Fenkes <FENKES@...ibm.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Hoang-Nam Nguyen <hnguyen@...ux.vnet.ibm.com>, johnrose@...ibm.com,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	paulus@...ba.org, pmac@....ibm.com, Sylvain Munaut <tnt@...tnt.com>
Subject: Re: [PATCH 2.6.21-rc1] powerpc: Make of_device_uevent()	compatible	with
 ibmebus

Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote on 17.02.2007 
19:37:25:

> > > Doh ! You are creating an of_device with no attached device-node ? 
That
> > > is totally evil ! Why do you need that ?
> > 
> > The driver creates a fake "ibmebus" device so all ibmebus based 
devices 
> > have
> > a common parent device -- the vio bus does the same.
> > 
> > What do you think about linking this device to the device tree "/" 
node? 
> > All
> > ibmebus-based devices are linked to dt nodes residing directly beneath 

> > "/",
> > so the mapping would fit.
> 
> No. If you do that, it shouldn't be an of_device based device.
> 
> If you want then to be below a common parent, then create that parent of
> a basic struct device type, that sort of thing. You should never
> instanciate an of_device that has a NULL device node.

If I make the root device a basic struct device, it can't be part of 
ibmebus any
longer. If we could create a busless device, we wouldn't have a problem, 
but I
doubt that is possible.

Do you have any creative ideas?
 
> It's a generic problem with sysfs, I agree it somewhat sucks.

With ya.

Later,
  Joachim

---
Joachim Fenkes  --  eHCA Linux Driver Developer and Hardware Tamer 
extraordinaire
IBM Deutschland Entwicklung GmbH  --  Dept. 3627 (I/O Firmware Development 
2)
Schoenaicher Strasse 220  --  71032 Boeblingen  --  Germany
eMail: fenkes@...ibm.com  --  Phone: +49 7031 16 1239 

Vorsitzender des Aufsichtsrats: Johann Weihen  --  Geschäftsführung: 
Herbert Kircher
Sitz der Gesellschaft: Böblingen  --  Registergericht: Amtsgericht 
Stuttgart, HRB 243294
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/