linux-kernel - Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Feb 2007 16:50:48 -0500
From:	Chris Mason <chris.mason@...cle.com>
To:	"Ananiev, Leonid I" <leonid.i.ananiev@...el.com>
Cc:	Zach Brown <zach.brown@...cle.com>, linux-aio@...ck.org,
	linux-kernel@...r.kernel.org, Benjamin LaHaise <bcrl@...ck.org>,
	Suparna bhattacharya <suparna@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] aio: propogate post-EIOCBQUEUED errors to completion event

On Mon, Feb 19, 2007 at 11:58:16PM +0300, Ananiev, Leonid I wrote:
> > while triggering EIO in invalidate_inode_pages2_range() 
> ...
> > With this patch aio-stress sees -EIO.
> 
> Actually if invalidate_inode_pages2_range() returns EIO it means
> that internal kernel synchronization conflict was happen.
> It is reported to user as hardware IO error.
> Iteration in synchronization process could be performed instead.
> 

aio is not responsible for this particular synchronization.  Those fixes
(if we make them) should come from other places.  The patch is important
to get aio error handling right.

I would argue that one common cause of the EIO is userland
error (mmap concurrent with O_DIRECT), and EIO is the correct answer.

-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/