[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20070220165638.GA6254@ccure.user-mode-linux.org>
Date: Tue, 20 Feb 2007 11:56:38 -0500
From: Jeff Dike <jdike@...toit.com>
To: akpm@...l.org
Cc: "Paolo 'Blaisorblade' Giarrusso" <blaisorblade@...oo.it>,
linux-kernel@...r.kernel.org, user-mode-linux@...ts.sourceforge.net
Subject: [PATCH 3/3] UML - pte_mkread fix
Fix the fact that pte_mkread set _PAGE_RW instead of _PAGE_USER (the logic is
copied from i386 in most place, so it is really as bad as you're thinking).
Thus currently page tables are more permissive than they should.
Such a change may trigger other latent bugs, so be careful with this.
Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@...oo.it>
Signed-off-by: Jeff Dike <jdike@...toit.com>
--
include/asm-um/pgtable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.18-mm/include/asm-um/pgtable.h
===================================================================
--- linux-2.6.18-mm.orig/include/asm-um/pgtable.h 2006-10-03 12:53:16.000000000 -0400
+++ linux-2.6.18-mm/include/asm-um/pgtable.h 2006-10-09 12:25:44.000000000 -0400
@@ -270,7 +270,7 @@ static inline pte_t pte_wrprotect(pte_t
static inline pte_t pte_mkread(pte_t pte)
{
- pte_set_bits(pte, _PAGE_RW);
+ pte_set_bits(pte, _PAGE_USER);
return(pte_mknewprot(pte));
}
--
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists