[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070220002145.GP13958@stusta.de>
Date: Tue, 20 Feb 2007 01:21:45 +0100
From: Adrian Bunk <bunk@...sta.de>
To: Dave Jones <davej@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Alexey Dobriyan <adobriyan@...nvz.org>,
linux-kernel@...r.kernel.org
Subject: Re: [-mm patch] {rd,wr}msr_on_cpu SMP=n optimization
On Mon, Feb 19, 2007 at 07:14:34PM -0500, Dave Jones wrote:
> On Tue, Feb 20, 2007 at 01:07:13AM +0100, Adrian Bunk wrote:
>...
> > +#ifdef CONFIG_SMP
> > void rdmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 *l, u32 *h);
> > void wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h);
> > +#else /* CONFIG_SMP */
> > +static inline void rdmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 *l, u32 *h)
> > +{
> > + rdmsr(msr_no, *l, *h);
> > +}
> > +static inline void wrmsr_on_cpu(unsigned int cpu, u32 msr_no, u32 l, u32 h)
> > +{
> > + wrmsr(msr_no, l, h);
> > +}
> > +#endif /* CONFIG_SMP */
>
> BUG_ON(cpu!=smp_processor_id()) maybe?
This is the CONFIG_SMP=n case.
> Dave
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists