linux-kernel - Re: [PATCH 1/3] slab: introduce krealloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 21 Feb 2007 09:53:15 -0800 (PST)
From:	Christoph Lameter <clameter@....com>
To:	Pekka J Enberg <penberg@...helsinki.fi>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	jsipek@....cs.sunysb.edu, unionfs@...esystems.org, bunk@...sta.de,
	hooanon05@...oo.co.jp
Subject: Re: [PATCH 1/3] slab: introduce krealloc

On Wed, 21 Feb 2007, Pekka J Enberg wrote:

> +void *krealloc(const void *p, size_t new_size, gfp_t flags)
> +{
> +	void *ret;
> +
> +	if (unlikely(!p))
> +		return kmalloc_track_caller(new_size, flags);
> +
> +	if (unlikely(!new_size)) {
> +		kfree(p);
> +		return NULL;
> +	}
> +
> +	ret = kmalloc_track_caller(new_size, flags);
> +	if (!ret)
> +		return NULL;
> +
> +	memcpy(ret, p, min(new_size, ksize(p)));
> +	kfree(p);
> +	return ret;
> +}
> +EXPORT_SYMBOL(krealloc);

Well could you check ksize for the old object first and if ksize <= new 
size then just skip the copy? I think this may allow you 
to get rid of the ksize callers.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/