linux-kernel - RE: questions about 8250 uart support for adhoc boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <028501c75aa2$54ae9d80$294b82ce@stuartm>
Date:	Tue, 27 Feb 2007 14:06:04 -0500
From:	"Stuart MacDonald" <stuartm@...necttech.com>
To:	"'Russell King'" <rmk+lkml@....linux.org.uk>,
	"'Rob Prowel'" <prowel@...hera.com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: RE: questions about 8250 uart support for adhoc boards

From: Russell King [mailto:rmk@....linux.org.uk]
> After experimenting here, it turns out the reason is you're trying to
> configure a port with a zero base baud.  Unfortunately, it starts off
> as zero.

That explains why adding the fourport module fixed Rob's issue, as the
fourport code sets a uartclk value for its ports.

> However, when you try to change a port without specifying the 
> base baud,
> it is possible for the port to become "usable" and unless we enforce
> the "must not have zero base baud" rule we have the 
> possibility to oops
> the kernel via a divide by zero.
> 
> So, the answer is to specify the base baud when using setserial to
> configure new ports.

Would it be more intuitive to give ports the default uartclk of
1843200 at init time? That would avoid this issue, but would make the
baud rates come out wrong on hardware with a non-standard clock, if a
base baud wasn't specified.


From: Rob Prowel [mailto:prowel@...hera.com] 
> your website address didn't work when I tried it...

The website may have been down on the weekend for maintenance. Please
try again.

..Stu

-- 
We make multiport serial products.
http://www.connecttech.com/
(800) 426-8979

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/