linux-kernel - Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0702281837200.4255@jikos.suse.cz>
Date:	Wed, 28 Feb 2007 18:41:53 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [GIT PATCH] HID and USB HID update for 2.6.21-rc2

On Wed, 28 Feb 2007, Linus Torvalds wrote:

> There is no excuse for putting a large array in a header file and 
> including it millions of times. Or even just twice. The point of a 
> header file is to *declare* things, not to have big data structures in.

The point was that noone else than hid/hid-core.c would ever be going to 
include this header with blacklist. The blacklist is growing in time quite 
rapidly and having it in the middle of the code just didn't look pretty - 
currently you have to perform some scrolling effort just to skip from 
usbhid_init_reports() to hid_find_max_report(), which just looks very sad 
to me.

But OK, I will leave it in there.

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/