lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 04 Mar 2007 13:14:45 -0500
From:	Stephen Clark <Stephen.Clark@...lark.us>
To:	Bill Davidsen <davidsen@....com>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>, Jeff Garzik <jeff@...zik.org>,
	Robert Hancock <hancockr@...w.ca>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] libata: warn if speed limited due to 40-wire cable (v2)

Bill Davidsen wrote:

>Alan Cox wrote:
>  
>
>>>it seems broken to manipulate xfer_mask after returning from the 
>>>driver's ->mode_filter hook.
>>>
>>>this patch is more than just a speed-limited warning printk, afaics
>>>      
>>>
>>I actually suggested that order because the only way the printk can be
>>done correctly is for it to be the very last test made. Since the mode
>>filter is not told what mode will be used but just subtracts modes that
>>are not allowed this should be safe.
>>    
>>
>
>Far better to have a drive which works slowly than one which works 
>unreliably.
>
>  
>
That would be true if the 40 wire detection was 100% accurate!

-- 

"They that give up essential liberty to obtain temporary safety, 
deserve neither liberty nor safety."  (Ben Franklin)

"The course of history shows that as a government grows, liberty 
decreases."  (Thomas Jefferson)



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists