[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070305165648.518964015@mvista.com>
Date: Mon, 05 Mar 2007 08:56:48 -0800
From: Daniel Walker <dwalker@...sta.com>
To: akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org, johnstul@...ibm.com
Subject: [PATCH] fix vsyscall settimeofday
I've only seen this on x86_64 .
The vsyscall state only gets updated when a timer interrupts comes in . So
if the time is set long before the next timer, there will be a period when
a gettimeofday() won't reflect the correct time.
I added an explicit update_vsyscall() during the settimeofday(), that way
the vsyscall state doesn't get stale.
Any thought John?
Signed-Off-By: Daniel Walker <dwalker@...sta.com>
---
kernel/timer.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.20/kernel/timer.c
===================================================================
--- linux-2.6.20.orig/kernel/timer.c
+++ linux-2.6.20/kernel/timer.c
@@ -861,6 +861,8 @@ int do_settimeofday(struct timespec *tv)
clock->error = 0;
ntp_clear();
+ update_vsyscall(&xtime, clock);
+
write_sequnlock_irqrestore(&xtime_lock, flags);
/* signal hrtimers about time change */
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists