linux-kernel - Re: should RTS init in serial core be tied to CRTSCTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0703051013u5732e127t598ae008e6f5894@mail.gmail.com>
Date:	Mon, 5 Mar 2007 13:13:14 -0500
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	linux-serial@...r.kernel.org,
	"Robin Getz" <rgetz@...ckfin.uclinux.org>
Subject: Re: should RTS init in serial core be tied to CRTSCTS

On 3/5/07, Russell King <rmk+lkml@....linux.org.uk> wrote:
> On Mon, Mar 05, 2007 at 12:09:20PM -0500, Mike Frysinger wrote:
> > On 3/4/07, Russell King <rmk+lkml@....linux.org.uk> wrote:
> > >On Thu, Mar 01, 2007 at 07:03:02PM -0500, Mike Frysinger wrote:
> > >> the console= bootcmd allows for controlling of the initial state of
> > >> flow control by adding/omitting the 'r' suffix ...
> > >
> > >The console command *only* sets the state for the kernel's use of one
> > >serial port.  It does not affect any other serial port, so tying
> > >random RTS behaviours into that command line option is absolutely
> > >silly.
> >
> > true ... so ignoring the original motivation for change i posted, is
> > it really correct for the serial core to be forcing TIOCM_RTS at uart
> > startup even though the uart doesnt have CTSRTS flow control enabled ?
> > in other words, my change is agnostic of the console, and is done for
> > all uarts ... it should prob have a similar change in uart_shutdown()
> > though ...
>
> No idea - it's something that Linux has always done.  Neither do I have
> any idea if changing it will break anyones setup.  However, since I don't
> maintain serial anymore, I'm not about to start playing about with this
> trying to find out.

ok, i was going by Documentation/serial/driver:
... any questions you have should be directed to <rmk@....linux.org.uk>
guessing that should be updated ? :)

> Feel free to submit a patch to akpm to leave RTS alone when CRTSCTS is
> not set.  I'd recommend that it sits in -mm for about 6 months to really
> get an idea if it breaks anything.

sounds good to me, thanks
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/