lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070306072706.GA22458@infradead.org>
Date:	Tue, 6 Mar 2007 07:27:06 +0000
From:	Christoph Hellwig <hch@...radead.org>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [S390] system call cleanup.

> +	struct pt_regs *regs = task_pt_regs(current);
> +	char *filename;
> +	unsigned long result;
> +	int rc;
> +
> +	filename = getname(compat_ptr(regs->orig_gpr2));
> +	if (IS_ERR(filename)) {
> +		result = PTR_ERR(filename);
>                  goto out;

The old code here..

> +	struct pt_regs *regs = task_pt_regs(current);
>          unsigned long clone_flags;
>          unsigned long newsp;
>  	int __user *parent_tidptr, *child_tidptr;

..and here..

> +asmlinkage long sys_clone(void)
>  {
> +	struct pt_regs *regs = task_pt_regs(current);
>          unsigned long clone_flags;
>          unsigned long newsp;
>  	int __user *parent_tidptr, *child_tidptr;

..and here used spaces instead of tabs, it would be nice to clean this
up while you're at it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ