linux-kernel - Re: [S390] system call cleanup.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1173172876.24596.0.camel@localhost>
Date:	Tue, 06 Mar 2007 10:21:16 +0100
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [S390] system call cleanup.

On Tue, 2007-03-06 at 07:27 +0000, Christoph Hellwig wrote:
> > +	struct pt_regs *regs = task_pt_regs(current);
> > +	char *filename;
> > +	unsigned long result;
> > +	int rc;
> > +
> > +	filename = getname(compat_ptr(regs->orig_gpr2));
> > +	if (IS_ERR(filename)) {
> > +		result = PTR_ERR(filename);
> >                  goto out;
> 
> The old code here..
> 
> > +	struct pt_regs *regs = task_pt_regs(current);
> >          unsigned long clone_flags;
> >          unsigned long newsp;
> >  	int __user *parent_tidptr, *child_tidptr;
> 
> ..and here..
> 
> > +asmlinkage long sys_clone(void)
> >  {
> > +	struct pt_regs *regs = task_pt_regs(current);
> >          unsigned long clone_flags;
> >          unsigned long newsp;
> >  	int __user *parent_tidptr, *child_tidptr;
> 
> ..and here used spaces instead of tabs, it would be nice to clean this
> up while you're at it.

Will do, thanks for the hint.

-- 
blue skies,              IBM Deutschland Entwicklung GmbH
   Martin                Vorsitzender des Aufsichtsrats: Johann Weihen
                         Geschäftsführung: Herbert Kircher
Martin Schwidefsky       Sitz der Gesellschaft: Böblingen
Linux on zSeries         Registergericht: Amtsgericht Stuttgart,
   Development           HRB 243294

"Reality continues to ruin my life." - Calvin.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/