linux-kernel - Re: [uml-devel] [PATCH 4/5] UML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200703062007.16943.blaisorblade@yahoo.it>
Date:	Tue, 6 Mar 2007 20:07:16 +0100
From:	Blaisorblade <blaisorblade@...oo.it>
To:	user-mode-linux-devel@...ts.sourceforge.net
Cc:	Jeff Dike <jdike@...toit.com>, akpm@...l.org,
	linux-kernel@...r.kernel.org
Subject: Re: [uml-devel] [PATCH 4/5] UML - driver formatting fixes

On Tuesday 06 March 2007 19:32, Jeff Dike wrote:
> Fix a bunch of formatting violations in the drivers:
> 	return(n) -> return n
> 	whitespace fixes
> 	emacs formatting comment removal
> 	breaking if(foo) return(n) into two lines
>
> There are also a couple of errno use bugs:
> 	using errno in a printk when the failure put errno into a local variable
> 	saving errno after a printk, which can change it
>
> Signed-off-by: Jeff Dike <jdike@...ux.intel.com>

> Index: test/arch/um/drivers/chan_user.c
> ===================================================================
> --- test.orig/arch/um/drivers/chan_user.c	2007-03-06 12:09:47.000000000
> -0500 +++ test/arch/um/drivers/chan_user.c	2007-03-06 12:10:12.000000000
> -0500 @@ -158,7 +158,7 @@ static int winch_tramp(int fd, struct tt
>  	 */
>  	err = run_helper_thread(winch_thread, &data, CLONE_FILES, &stack, 0);
>  	if(err < 0){
> -		printk("fork of winch_thread failed - errno = %d\n", errno);
> +		printk("fork of winch_thread failed - errno = %d\n", err);
>  		goto out_close;
>  	}

The second line should better say -err instead of err.
-- 
Inform me of my mistakes, so I can add them to my list!
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/