[<prev] [next>] [day] [month] [year] [list]
Message-Id: <1173208395.5266.5.camel@dix>
Date: Tue, 06 Mar 2007 20:13:15 +0100
From: Martin Peschke <mp3@...ibm.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
Wu Fengguang <wfg@...l.ustc.edu.cn>
Subject: [Patch] small lib/parser.c cleanup
simplifying code by using available string duplication function
Signed-off-by: Martin Peschke <mp3@...ibm.com>
---
parser.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
Index: linux/lib/parser.c
===================================================================
--- linux.orig/lib/parser.c
+++ linux/lib/parser.c
@@ -126,11 +126,9 @@ static int match_number(substring_t *s,
char *buf;
int ret;
- buf = kmalloc(s->to - s->from + 1, GFP_KERNEL);
+ buf = match_strdup(s);
if (!buf)
return -ENOMEM;
- memcpy(buf, s->from, s->to - s->from);
- buf[s->to - s->from] = '\0';
*result = simple_strtol(buf, &endp, base);
ret = 0;
if (endp == buf)
@@ -155,11 +153,9 @@ int match_s64(substring_t *s, s64 *resul
char *buf;
int ret;
- buf = kmalloc(s->to - s->from + 1, GFP_KERNEL);
+ buf = match_strdup(s);
if (!buf)
return -ENOMEM;
- memcpy(buf, s->from, s->to - s->from);
- buf[s->to - s->from] = '\0';
*result = simple_strtoll(buf, &endp, base);
ret = 0;
if (endp == buf)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists