linux-kernel - Re: [PATCH 2/3] msi: Fixup the msi enable/disable logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1wt1td41h.fsf@ebiederm.dsl.xmission.com>
Date:	Tue, 06 Mar 2007 22:19:06 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	michael@...erman.id.au
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...ey.karlin.mff.cuni.cz,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 2/3] msi:  Fixup the msi enable/disable logic

Michael Ellerman <michael@...erman.id.au> writes:

>
> Hi Eric, comments below ..
>
>
> I get the reasoning for disabling MSI before we start writing back the
> config space, but don't we want to re-enable MSI on the way out?

We are restoring the entire msi flags register which includes the enable bit,
setting it a second time is gratuitous.

In addition if we are restoring the register when the enable bit is not set.
(because we don't have a mask bit) enabling the msi state is actually
the wrong thing to do.    But I admit that case can only happen after
the additions in my last patch.

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/