| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.64.0703070735240.5963@woody.linux-foundation.org> Date: Wed, 7 Mar 2007 07:39:00 -0800 (PST) From: Linus Torvalds <torvalds@...ux-foundation.org> To: Benjamin Herrenschmidt <benh@...nel.crashing.org> cc: Greg KH <greg@...ah.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: Linux v2.6.21-rc3 On Wed, 7 Mar 2007, Benjamin Herrenschmidt wrote: > > On Tue, 2007-03-06 at 20:59 -0800, Linus Torvalds wrote: > > > Linus Torvalds (2): > > Revert "[PATCH] LOG2: Alter get_order() so that it can make use of ilog2() on a constant" > > Linux 2.6.21-rc3 > > Greg, I think we should revert that patch in 2.6.20.x stable serie too > as get_order is broken there as well, causing random kernel memory > corruption every now and then among others. Did you confirm that that was indeed the cause of the problem you saw? As far as I can tell, the bug (because it tested the wrong #define) would only affect the constant-size case, and only for something larger than a single page, and only for a non-power-of-two size. So it looked fairly hard to trigger, if only because all the obvious constants I saw seemed to already be powers-of-two.. So did you hunt it down to a particular cases where it triggers? Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists