linux-kernel - Re: [patch 1/4] signalfd v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0703070854280.5963@woody.linux-foundation.org>
Date:	Wed, 7 Mar 2007 08:57:28 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
cc:	Davide Libenzi <davidel@...ilserver.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 1/4] signalfd v1 - signalfd core ...

On Wed, 7 Mar 2007, Stephen Rothwell wrote:
> 
> You probably need the queue anyway because the real time signals are
> supposed to queue.

Davide - the *real* problem is (I think) that you try to allow signals to 
be returned *both* by signalfd() and as a real signal.

That's wrong, wrong, wrong.

My original patch used "dequeue_signal()" to dequeue signals. Trust me, I 
did that for a reason. Your re-design to think that you can get the signal 
without using the real signal dequeueing is simply broken.

The signalfd must be an "either or" thing. Either you get it as a real 
signal, or you get it off the signalfd(). Not both. Not neither.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/