linux-kernel - Re: [PATCH 12/20] x86_64: 64bit ACPI wakeup trampoline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070308114422.GE5953@elf.ucw.cz>
Date:	Thu, 8 Mar 2007 12:44:22 +0100
From:	Pavel Machek <pavel@....cz>
To:	Vivek Goyal <vgoyal@...ibm.com>
Cc:	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Reloc Kernel List <fastboot@...ts.osdl.org>,
	ebiederm@...ssion.com, akpm@...ux-foundation.org, ak@...e.de,
	hpa@...or.com, magnus.damm@...il.com, lwang@...hat.com,
	dzickus@...hat.com, rjw@...k.pl
Subject: Re: [PATCH 12/20] x86_64: 64bit ACPI wakeup trampoline

Hi!

> > ...you'll still keep 80-column rule while keeping it readable.
> > 
> 
> Thanks. Done the changes in attached patch.
> 
> > > @@ -159,11 +159,11 @@ wakeup_32:
> > >  	 */
> > >  
> > >  	/* Finally jump in 64bit mode */
> > > -	ljmp	*(wakeup_long64_vector - __START_KERNEL_map)
> > > +        ljmp    *(wakeup_long64_vector - wakeup_code)(%esi)
> > 
> > spaces vs. tabs problem.
> > 
> 
> Thanks. Done the changes in attached patch.
...
> o Increased the size of the wakeup routine to 8K. This is required as
>   wake page tables are on trampoline itself and they got to be at 4K
>   boundary, hence one page is not sufficient.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
> Signed-off-by: Vivek Goyal <vgoyal@...ibm.com>

ACK.
								Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/