linux-kernel - Re: [PATCH 16/20] swsusp: do not use virt_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070308114443.GF5953@elf.ucw.cz>
Date:	Thu, 8 Mar 2007 12:44:43 +0100
From:	Pavel Machek <pavel@....cz>
To:	Vivek Goyal <vgoyal@...ibm.com>
Cc:	linux kernel mailing list <linux-kernel@...r.kernel.org>,
	Reloc Kernel List <fastboot@...ts.osdl.org>,
	ebiederm@...ssion.com, akpm@...ux-foundation.org, ak@...e.de,
	hpa@...or.com, magnus.damm@...il.com, lwang@...hat.com,
	dzickus@...hat.com, rjw@...k.pl
Subject: Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address

Hi!

> > > o virt_to_page() call should be used on kernel linear addresses and not
> > >   on kernel text and data addresses. Swsusp code uses it on kernel data
> > >   (statically allocated swsusp_header).
> > > 
> > > o Allocate swsusp_header dynamically so that virt_to_page() can be used
> > >   safely.
> > > 
> > > o I am changing this because in next few patches, __pa() on x86_64 will
> > >   no longer support kernel text and data addresses and hibernation breaks. 
> > > 
> > > Signed-off-by: Vivek Goyal <vgoyal@...ibm.com>
> > 
> > (I assume this was tested, too?)
> 
> Yes. I have tested this and it works fine.

ACK from me, then.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/