lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Mar 2007 12:47:12 +0100 From: Pavel Machek <pavel@....cz> To: Vivek Goyal <vgoyal@...ibm.com> Cc: linux kernel mailing list <linux-kernel@...r.kernel.org>, Reloc Kernel List <fastboot@...ts.osdl.org>, ebiederm@...ssion.com, akpm@...ux-foundation.org, ak@...e.de, hpa@...or.com, magnus.damm@...il.com, lwang@...hat.com, dzickus@...hat.com, rjw@...k.pl Subject: Re: [PATCH 16/20] swsusp: do not use virt_to_page on kernel data address Hi! > > > Signed-off-by: Vivek Goyal <vgoyal@...ibm.com> > > > > > +static int swsusp_header_init(void) > > > +{ > > > + swsusp_header = (struct swsusp_header*) __get_free_page(GFP_KERNEL); > > > + if (!swsusp_header) > > > + panic("Could not allocate memory for swsusp_header\n"); > > > + return 0; > > > +} > > > + > > > +core_initcall(swsusp_header_init); > > > > I do not like the panic, but I guess it is okay as we are running > > during boot? (Could you add a comment?) Otherwise ok. > > > > Hi Pavel, > > Yes, it is an initcall and this memory page will be allocated during > boot time. Not very sure what comment to put there. To me it seems > pretty obivious with "core_initcall". I'd put "/* running at boot time, so allocation can't fail */" there (and maybe just replace panic with BUG_ON), but I guess that's not important. ACK. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists