lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 7 Mar 2007 19:08:58 -0500
From:	Dave Jones <davej@...hat.com>
To:	"Robert P. J. Day" <rpjday@...dspring.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] Replace misspelled "PRINTK" with "CONFIG_PRINTK".

On Wed, Mar 07, 2007 at 06:38:32PM -0500, Robert P. J. Day wrote:
 > 
 >   Replace the apparently misspelled preprocessor variable "PRINTK"
 > with "CONFIG_PRINTK".

this looks wrong.
 
 > diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
 > index 5554ada..0c09772 100644
 > --- a/drivers/md/bitmap.c
 > +++ b/drivers/md/bitmap.c
 > @@ -53,7 +53,7 @@
 >  //#define DPRINTK PRINTK /* set this NULL to avoid verbose debug output */
 >  #define DPRINTK(x...) do { } while(0)
 > 
 > -#ifndef PRINTK
 > +#ifndef CONFIG_PRINTK
 >  #  if DEBUG > 0
 >  #    define PRINTK(x...) printk(KERN_DEBUG x)
 >  #  else

the intention here is to only define 'PRINTK' if no-one else
has defined it already.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists