linux-kernel - Re: [PATCH 3/7] revoke: core code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0703091316550.10951@sbz-30.cs.Helsinki.FI>
Date:	Fri, 9 Mar 2007 13:42:39 +0200 (EET)
From:	Pekka J Enberg <penberg@...helsinki.fi>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	hch@...radead.org, serue@...ibm.com
Subject: Re: [PATCH 3/7] revoke: core code

On Fri, 9 Mar 2007 10:15:15 +0200 (EET)
Pekka J Enberg <penberg@...helsinki.fi> wrote:
> > +static ssize_t revoked_file_aio_read(struct kiocb *iocb,
> > +				     const struct iovec *iov,
> > +				     unsigned long nr_segs, loff_t pos)
> > +{
> > +	return -EBADF;
> > +}
 
On Fri, 9 Mar 2007, Alan Cox wrote:
> Do we need both -EBADF and -EXNIO versions. It is hard to tell from
> existing OS's as they don't support revoke of files just special files ?

No, we don't. We should always do EBADF except for close(2) which is zero 
always and make read(2) zero for special files.

On Fri, 9 Mar 2007 10:15:15 +0200 (EET)
Pekka J Enberg <penberg@...helsinki.fi> wrote:
> > +static ssize_t revoked_special_file_read(struct file *filp, char __user * buf,
> > +					 size_t size, loff_t * ppos)
> > +{
> > +	return -ENXIO;
> > +}

On Fri, 9 Mar 2007, Alan Cox wrote:
> Bezerkly Unix returns 0 for the special file read case

Aah, I'll fix that up. Thanks.

				Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/