linux-kernel - Re: [PATCH 2.6.22] remove Intel combined mode quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200703091156.02955.jbarnes@virtuousgeek.org>
Date:	Fri, 9 Mar 2007 11:56:01 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 2.6.22] remove Intel combined mode quirk

On Friday, March 9, 2007 8:01 am Jeff Garzik wrote:
> Discussed for 2.6.21, but pushed back because the current SATA code
> had enough fun stuff to debug already.  Thus, just queued the
> following for 2.6.22 in libata-dev.git#upstream.
>
> The nasty ____request_resource hack is finally gone.
>
> In practical terms, this usually means that some combined mode users
> will have their SATA devices driven by the old-IDE driver rather than
> libata (because old-IDE is often non-modular, and thus probes first).
>
> But really, these same users will IMO cheer the removal of the
> performance-killing split-driver configuration, so its a net win.
> And the code is smaller and more clean, with one less special case
> hack.
>
>     libata/IDE: remove combined mode quirk
>
>     Both old-IDE and libata should be able handle all controllers and
>     devices found using normal resource reservation methods.
>
>     This eliminates the awful, low-performing split-driver
> configuration where old-IDE drove the PATA portion of a PCI device,
> in PIO-only mode, and libata drove the SATA portion of the /same/ PCI
> device, in DMA mode. Typically vendors would ship SATA hard drive /
> PATA optical configuration, which would lend itself to slow
> (PIO-only) CD-ROM performance.
>
>     For Intel users running in combined mode, it is now wholly
> dependent on your driver choice (potentially link order, if you
> compile both drivers in) whether old-IDE or libata will drive your
> hardware.
>
>     In either case, you will get full performance from both SATA and
> PATA ports now, without having to pass a kernel command line
> parameter.
>
>     Signed-off-by: Jeff Garzik <jeff@...zik.org>

Yay!  I'm glad we can finally get rid of this in favor of the new pata 
drivers.  Don't forget to kill the stuff in 
Documentation/kernel-parameters.txt though.

Acked-by:  Jesse Barnes <jbarnes@...tuousgeek.org>

Jesse
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/