linux-kernel - Re: [PATCH] MPT FUSION: Delete unused header files.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45F5AD8E.2080105@drugphish.ch>
Date:	Mon, 12 Mar 2007 20:44:14 +0100
From:	Roberto Nibali <ratz@...gphish.ch>
To:	"Moore, Eric" <Eric.Moore@....com>
Cc:	Valdis.Kletnieks@...edu,
	"Robert P. J. Day" <rpjday@...dspring.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] MPT FUSION: Delete unused header files.

>> Certainly appropriate content for something on your website, 
>> and vendors who
>> provide programs like dmidecode and parsemce are always 
>> welcome. I could
>> probably be convinced that such info should have at least a 
>> pointer somewhere
>> in Documentation/lsi_debug.txt or some such.  But quite 
>> frankly, if I'm reduced
>> to wading through *.h files to figure out what some 
>> recalcitrant hardware is
>> upset about, there's been a failure in documentation.  
>> *ESPECIALLY* if I
>> go look at drivers/whatever/source.c and it doesn't even 
>> *reference* the *.h
>> file in question.
> 
> 
> Its apparent to me that you don't have our hardware, nor have you
> actually waded thru this driver source code. 

Allow me to shortly chime in here:

I'm the author of the mpt-status user space tool (a simple alternative 
to your Java GUI tool), which queries LSI controllers and reports back 
the RAID status and the synchronization state; so I have waded through 
the driver source code quite a lot. My question:

> If you did, you would of noticed that the header you want to delete, is
> actually referenced in the *.c source code.   The file "mpi_log_fc.h",
> is indeed mentioned in mptbase.c, in the function called
> mpt_fc_log_info, in the documention section above the function.    This
> header file is very helpful to those supporting our hardware, and those
> using it
> For SAS(mpi_log_sas.h), I have broken out each loginfo in the strings
> you will find defined in originator_str, iop_code_str, pl_code_str, etc,
> I probably do that with fibre.
> 
> If its that important to you to have the header files included, I will
> provide a patch that does that.    

I would really like to see "sanitized" kernel headers, so is it possible 
to have your headers inside ../drivers/message/fusion{,/lsi} somehow 
inserted into the process of the headers_install target?

Best regards,
Roberto Nibali, ratz
-- 
echo 
'[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/