linux-kernel - Re: [PATCH] libata: don't whine if ->prereset() returns -ENOENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b637ec0b0703121314o747ef0bdl5c9f580b456bae43@mail.gmail.com>
Date:	Mon, 12 Mar 2007 21:14:03 +0100
From:	"Fabio Comolli" <fabio.comolli@...il.com>
To:	"Tejun Heo" <htejun@...il.com>
Cc:	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Jeff Garzik" <jeff@...zik.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	"Greg KH" <greg@...ah.com>
Subject: Re: [PATCH] libata: don't whine if ->prereset() returns -ENOENT

Applied on top of latest GIT this patch make the warning[1] disappear.
Thanks,
Fabio

[1] ata2: reset failed, giving up

On 3/12/07, Tejun Heo <htejun@...il.com> wrote:
> ->prereset() returns -ENOENT to tell libata that the port is empty and
> reset sequencing should be stopped.  This is not an error condition.
> Update ata_eh_reset() such that it sets device classes to ATA_DEV_NONE
> and return success in on -ENOENT.  This makes spurious error message
> go away.
>
> Signed-off-by: Tejun Heo <htejun@...il.com>
> ---
>
> This should do it and better fits the intention of the return value.
> Two things to note.
>
> 1. I think these ports should be made dummy instead of returning
> -ENOENT on prereset().  -ENOENT from prereset() was a hack to keep
> ata_piix's behavior unchanged while converting it to new EH.  If no
> one objcts, I'll convert similar usages to use dummy ports after new
> init model and drop -ENOENT hack in #upstream.
>
> 2. -ENODEV sounds more appropriate.  Why have I used -ENOENT.  :-)
>
> Thanks.
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 7349c3d..361953a 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -1625,8 +1625,14 @@ static int ata_eh_reset(struct ata_port *ap, int classify,
>                 rc = prereset(ap);
>                 if (rc) {
>                         if (rc == -ENOENT) {
> -                               ata_port_printk(ap, KERN_DEBUG, "port disabled. ignoring.\n");
> +                               ata_port_printk(ap, KERN_DEBUG,
> +                                               "port disabled. ignoring.\n");
>                                 ap->eh_context.i.action &= ~ATA_EH_RESET_MASK;
> +
> +                               for (i = 0; i < ATA_MAX_DEVICES; i++)
> +                                       classes[i] = ATA_DEV_NONE;
> +
> +                               rc = 0;
>                         } else
>                                 ata_port_printk(ap, KERN_ERR,
>                                         "prereset failed (errno=%d)\n", rc);
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/