linux-kernel - Re: _proxy_pda still makes linking modules fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070312094805.GA11644@one.firstfloor.org>
Date:	Mon, 12 Mar 2007 10:48:05 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Marcin 'Qrczak' Kowalczyk <qrczak@....org.pl>,
	linux-kernel@...r.kernel.org, Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: _proxy_pda still makes linking modules fail

On Sun, Mar 11, 2007 at 05:25:46PM -0700, Jeremy Fitzhardinge wrote:
> Andi Kleen wrote:
> > Hmm, it probably needs a EXPORT_SYMBOL. The previous change only
> > fixed the in kernel build.
> >
> > Does it work with this patch?
> >
> > -Andi
> >
> > Export _proxy_pda for gcc 4.2
> >   
> 
> Gak.  It seemed like such a good idea at the time.

The problem is that the upcomming 4.2 has a more aggressive optimizer
and when there are two "m" (_proxy_pda...) references in the same
function it CSEs its address into a register. And that generates
code and a reference.

> 
> Rusty's pda->per_cpu patch will deal with this once and for all; have

Not on x86-64.

> you picked it up yet?

Not yet.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/