linux-kernel - Re: [PATCH] usb-serial regression fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200703131450.24462.oneukum@suse.de>
Date:	Tue, 13 Mar 2007 14:50:23 +0100
From:	Oliver Neukum <oneukum@...e.de>
To:	Mark Lord <lkml@....ca>
Cc:	Jim Radford <radford@...ckbean.org>, Greg KH <greg@...ah.com>,
	linux-usb-devel@...ts.sourceforge.net,
	Adrian Bunk <bunk@...sta.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb-serial regression fix

Am Dienstag, 13. März 2007 14:39 schrieb Mark Lord:
> Oliver Neukum wrote:
> >
> > If we get to destroy_serial(), how can ports still be open?
> 
> (1) open up a ckermit session on /dev/usb_serial_port_0.
> (2) suspend the machine (to RAM).
> (3) the suspend logic "removes" all USB devices.

No,

any open port has taken a reference in serial_open():
	serial = usb_serial_get_by_index(tty->index);

destroy_serial() can be called only when the refcount goes to zero. How
can there be open ports?

	Regards
		Oliver

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/