linux-kernel - Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070314103832.GA16104@elte.hu>
Date:	Wed, 14 Mar 2007 11:38:32 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Adrian Bunk <bunk@...sta.de>,
	Alexander Viro <viro@....linux.org.uk>
Subject: Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support


* Eric W. Biederman <ebiederm@...ssion.com> wrote:

> From: Eric W. Biederman <ebiederm@...ssion.com> - unquoted
> 
> With this change the sysctl inodes can be cached and nothing needs to 
> be done when removing a sysctl table.

your change is now upstream:

  commit 77b14db502cb85a031fe8fde6c85d52f3e0acb63
  Author: Eric W. Biederman <ebiederm@...ssion.com>
  Date:   Wed Feb 14 00:34:12 2007 -0800

but it broke the latency tracer in -rt which uses create_proc_entry() to 
attach a custom handler to value changes in preempt_max_latency:

 #define PROCNAME_PML    "sys/kernel/preempt_max_latency"

 static __init int latency_fs_init(void)
 {
         struct proc_dir_entry *entry;

         if (!(entry = create_proc_entry(PROCNAME_PML, 0644, NULL)))
                 printk("latency_fs_init(): can't create %s\n", PROCNAME_PML);

with your change that broke because beyond /proc/sys/ there are no real 
proc entries anymore, there's no de->subdir directory for 
xlate_proc_name() to find. While the latency tracer isnt upstream, this 
change in semantics does not seem to be intended (the changelog is 
certainly silent about it).

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/