linux-kernel - Re: [PATCH 14/17] atl1 trivial endianness misannotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45F9984A.4020206@redhat.com>
Date:	Thu, 15 Mar 2007 15:02:34 -0400
From:	Chris Snook <csnook@...hat.com>
To:	Al Viro <viro@....linux.org.uk>
CC:	torvalds@...ux-foundation.org, jgarzik@...ox.com,
	linux-kernel@...r.kernel.org, Jay Cliburn <jacliburn@...lsouth.net>
Subject: Re: [PATCH 14/17] atl1 trivial endianness misannotations

Al Viro wrote:
> NB: driver is choke-full of code that will break on big-endian; as long
> as the hardware is onboard-only we can live with that, but sooner or
> later that'll need fixing.
> 
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> ---
>  drivers/net/atl1/atl1_main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/atl1/atl1_main.c b/drivers/net/atl1/atl1_main.c
> index 88d4f70..dee3638 100644
> --- a/drivers/net/atl1/atl1_main.c
> +++ b/drivers/net/atl1/atl1_main.c
> @@ -1328,7 +1328,7 @@ static int atl1_tx_csum(struct atl1_adapter *adapter, struct sk_buff *skb,
>  
>  	if (likely(skb->ip_summed == CHECKSUM_PARTIAL)) {
>  		cso = skb->h.raw - skb->data;
> -		css = (skb->h.raw + skb->csum) - skb->data;
> +		css = (skb->h.raw + skb->csum_offset) - skb->data;
>  		if (unlikely(cso & 0x1)) {
>  			printk(KERN_DEBUG "%s: payload offset != even number\n",
>  				atl1_driver_name);

This could certainly explain some checksumming problems we've seen.

> @@ -1562,7 +1562,7 @@ static int atl1_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
>  	/* mss will be nonzero if we're doing segment offload (TSO/GSO) */
>  	mss = skb_shinfo(skb)->gso_size;
>  	if (mss) {
> -		if (skb->protocol == ntohs(ETH_P_IP)) {
> +		if (skb->protocol == htons(ETH_P_IP)) {
>  			proto_hdr_len = ((skb->h.raw - skb->data) +
>  					 (skb->h.th->doff << 2));
>  			if (unlikely(proto_hdr_len > len)) {

ACK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/