linux-kernel - Re: [PATCH] drivers/char/agp: Convert to generic boolean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <45FC9B54.4080209@student.ltu.se>
Date:	Sun, 18 Mar 2007 02:52:20 +0100
From:	Richard Knutsson <ricknu-0@...dent.ltu.se>
To:	Joe Perches <joe@...ches.com>
CC:	akpm@...ux-foundation.org, davej@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/char/agp: Convert to generic boolean

Please use "Reply All"

Joe Perches wrote:
> On Sun, 2007-03-18 at 00:45 +0100, Richard Knutsson wrote:
>   
>> diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c
>> index e6c534e..3d57e9f 100644
>> --- a/drivers/char/agp/amd-k7-agp.c
>> +++ b/drivers/char/agp/amd-k7-agp.c
>> @@ -308,9 +308,9 @@ static int amd_insert_memory(struct agp_memory *mem, off_t pg_start, int type)
>>  		j++;
>>  	}
>>  
>> -	if (mem->is_flushed == FALSE) {
>> +	if (!mem->is_flushed) {
>>  		global_cache_flush();
>> -		mem->is_flushed = TRUE;
>> +		mem->is_flushed = true;
>>  	}
>>     
>
> perhaps a generic.c / agp.h function?
>   
Sound like a good idea (not in a boolean cleanup-patch thou)
Would you mind making that patch?

Richard Knutsson

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/