linux-kernel - RE: [PATCH] usb/serial/whiteheat: Convert to generic boolean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <001101c76a33$4729b320$294b82ce@stuartm>
Date:	Mon, 19 Mar 2007 10:31:26 -0400
From:	"Stuart MacDonald" <stuartm@...necttech.com>
To:	"'Richard Knutsson'" <ricknu-0@...dent.ltu.se>,
	"'Andrew Morton'" <akpm@...l.org>
Cc:	<linux-kernel@...r.kernel.org>,
	<linux-usb-devel@...ts.sourceforge.net>
Subject: RE: [PATCH] usb/serial/whiteheat: Convert to generic boolean

From: Richard Knutsson [mailto:ricknu-0@...dent.ltu.se] 

Okay by me. Thanks Richard.

Signed-off-by: Stuart MacDonald <stuartm@...necttech.com>

..Stu

> Signed-off-by: Richard Knutsson <ricknu-0@...dent.ltu.se>
> ---
> Compile-tested with "allyes", "allmod" & "allno" on i386
> 
> 
> diff --git a/drivers/usb/serial/whiteheat.c 
> b/drivers/usb/serial/whiteheat.c
> index bf16e9e..27c5f8f 100644
> --- a/drivers/usb/serial/whiteheat.c
> +++ b/drivers/usb/serial/whiteheat.c
> @@ -1109,7 +1109,7 @@ static int firm_send_command (struct 
> usb_serial_port *port, __u8 command, __u8 *
>  	command_port = port->serial->port[COMMAND_PORT];
>  	command_info = usb_get_serial_port_data(command_port);
>  	spin_lock_irqsave(&command_info->lock, flags);
> -	command_info->command_finished = FALSE;
> +	command_info->command_finished = false;
>  	
>  	transfer_buffer = (__u8 
> *)command_port->write_urb->transfer_buffer;
>  	transfer_buffer[0] = command;
> @@ -1124,12 +1124,12 @@ static int firm_send_command (struct 
> usb_serial_port *port, __u8 command, __u8 *
>  	spin_unlock_irqrestore(&command_info->lock, flags);
>  
>  	/* wait for the command to complete */
> -	wait_event_interruptible_timeout(command_info->wait_command, 
> -		(command_info->command_finished != FALSE), 
> COMMAND_TIMEOUT);
> +	wait_event_interruptible_timeout(command_info->wait_command,
> +		(bool)command_info->command_finished, COMMAND_TIMEOUT);
>  
>  	spin_lock_irqsave(&command_info->lock, flags);
>  
> -	if (command_info->command_finished == FALSE) {
> +	if (command_info->command_finished == false) {
>  		dbg("%s - command timed out.", __FUNCTION__);
>  		retval = -ETIMEDOUT;
>  		goto exit;
> diff --git a/drivers/usb/serial/whiteheat.h 
> b/drivers/usb/serial/whiteheat.h
> index d714eff..f160797 100644
> --- a/drivers/usb/serial/whiteheat.h
> +++ b/drivers/usb/serial/whiteheat.h
> @@ -20,10 +20,6 @@
>  #define __LINUX_USB_SERIAL_WHITEHEAT_H
>  
>  
> -#define FALSE	0
> -#define TRUE	1
> -
> -
>  /* WhiteHEAT commands */
>  #define WHITEHEAT_OPEN			1	/* open 
> the port */
>  #define WHITEHEAT_CLOSE			2	/* 
> close the port */
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/