linux-kernel - Re: [Fastboot] [PATCH] [REVIEW] Fix irqpoll on IA64 (timer interrupt != 0)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070319183710.GA23499@strauss.suse.de>
Date:	Mon, 19 Mar 2007 19:37:10 +0100
From:	Bernhard Walle <bwalle@...e.de>
To:	Jesper Juhl <jesper.juhl@...il.com>
Cc:	linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org,
	fastboot@...ts.osdl.org
Subject: Re: [Fastboot] [PATCH] [REVIEW] Fix irqpoll on IA64 (timer interrupt != 0)

* Jesper Juhl <jesper.juhl@...il.com> [2007-03-19 19:29]:
> >
> > -void
> > +int
> >  register_percpu_irq (ia64_vector vec, struct irqaction *action)
> >  {
> 
> Each and every function example in Documentation/CodingStyle has the
> return type on the same line as the function name, so why not get
> these in-line while you are modifying them anyway?

Because all other functions in that file are coded this way. I think
it looks better if you don't change the style in a particular file.
Am I wrong?

> int register_percpu_irq (ia64_vector vec, struct irqaction *action)
> 
> 
> > @@ -174,6 +175,13 @@ void note_interrupt(unsigned int irq, st
> >         desc->irqs_unhandled = 0;
> >  }
> >
> > +
> > +void set_timer_interrupt(unsigned int irq)
> 
> Just one blank line between functions, as pr CodingStyle:
>    "In source files, separate functions with one blank line.  ..."

Fixed (locally). I'll repost if I get feedback of the contents of the
patch.


Regards,
Bernhard

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/