linux-kernel - Re: [PATCH] lockdep: debug_show_all_locks & debug_show_held_locks vs. debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070322090652.GC15328@elte.hu>
Date:	Thu, 22 Mar 2007 10:06:52 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Jarek Poplawski <jarkao2@...pl>, Oleg Nesterov <oleg@...sign.ru>,
	Neil Brown <neilb@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Folkert van Heusden <folkert@...heusden.com>,
	linux-kernel@...r.kernel.org,
	"J. Bruce Fields" <bfields@...ldses.org>
Subject: Re: [PATCH] lockdep: debug_show_all_locks &  debug_show_held_locks vs. debug_locks


* Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:

> On Thu, 2007-03-22 at 07:57 +0100, Jarek Poplawski wrote:
> > And here is some addition.
> > 
> > [PATCH] lockdep: debug_show_all_locks &  debug_show_held_locks vs. debug_locks
> >  
> > lockdep's data shouldn't be used when debug_locks == 0
> > because it's not updated after this, so it's more misleading
> > than helpful.
> > 
> > PS: probably lockdep's current-> fields should be reset after
> > it turns debug_locks off: so, after printing a bug report, but
> > before return from exported functions, but there are really
> > a lot of these possibilities (e.g. after DEBUG_LOCKS_WARN_ON),
> > so, something could be missed. (Of course direct use of this
> > fields isn't recommended either.)
> > 
> > Reported-by: Folkert van Heusden <folkert@...heusden.com>
> > Inspired-by: Oleg Nesterov <oleg@...sign.ru>
> > Signed-off-by: Jarek Poplawski <jarkao2@...pl>
> 
> Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

Acked-by: Ingo Molnar <mingo@...e.hu>

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/